[Bug 2387827] Review Request: perl-Crypt-SysRandom - Perl interface to system randomness

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2387827

Petr Pisar <ppisar@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> ---
URL and Source0 addresses are usable. Ok.
Source0 archive (SHA-512
75d5d89e8d883560f24f4f617afbb57f8953c6f7b96c4934ff8a7d2251ffddffe372ee8b5411011cb4eae0e7d19d4a44dd8414146c50d6bdc9b489ba8a4a23a6)
is original. Ok.
Summary and description verified in lib/Crypt/SysRandom.pm. Ok.
License verified from lib/Crypt/SysRandom.pm, LICENSE, and README. Ok.
No XS code, noarch BuildArch is Ok.
Win32::API is not used. Ok.
Build-requires are Ok.

$ rpmlint perl-Crypt-SysRandom.spec
../SRPMS/perl-Crypt-SysRandom-0.007-1.fc44.src.rpm
../RPMS/noarch/perl-Crypt-SysRandom-0.007-1.fc44.noarch.rpm 
======================================== rpmlint session starts
=======================================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

perl-Crypt-SysRandom.noarch: E: spelling-error ('cryptographically',
'%description -l en_US cryptographically -> photographically, typographically,
topographically')
perl-Crypt-SysRandom.src: E: spelling-error ('cryptographically', '%description
-l en_US cryptographically -> photographically, typographically,
topographically')
perl-Crypt-SysRandom.noarch: E: incorrect-fsf-address
/usr/share/licenses/perl-Crypt-SysRandom/LICENSE
=== 2 packages and 1 specfiles checked; 3 errors, 0 warnings, 6 filtered, 3
badness; has taken 0.3 s ==
rpmlint is Ok.

$ rpm -q -lv -p  ../RPMS/noarch/perl-Crypt-SysRandom-0.007-1.fc44.noarch.rpm 
drwxr-xr-x    2 root     root                        0 Aug 11 02:00
/usr/share/doc/perl-Crypt-SysRandom
-rw-r--r--    1 root     root                      745 Feb  5  2025
/usr/share/doc/perl-Crypt-SysRandom/Changes
-rw-r--r--    1 root     root                      375 Feb  5  2025
/usr/share/doc/perl-Crypt-SysRandom/README
drwxr-xr-x    2 root     root                        0 Aug 11 02:00
/usr/share/licenses/perl-Crypt-SysRandom
-rw-r--r--    1 root     root                    19744 Feb  5  2025
/usr/share/licenses/perl-Crypt-SysRandom/LICENSE
-rw-r--r--    1 root     root                     1374 Aug 11 02:00
/usr/share/man/man3/Crypt::SysRandom.3pm.gz
drwxr-xr-x    2 root     root                        0 Aug 11 02:00
/usr/share/perl5/vendor_perl/Crypt
-rw-r--r--    1 root     root                     2388 Feb  5  2025
/usr/share/perl5/vendor_perl/Crypt/SysRandom.pm
File layout and permissions are Ok.

$ rpm -q --requires -p 
../RPMS/noarch/perl-Crypt-SysRandom-0.007-1.fc44.noarch.rpm | sort -f | uniq -c
      1 perl(Carp)
      1 perl(Crypt::SysRandom::XS)
      1 perl(Errno)
      1 perl(Exporter)
      1 perl(strict)
      1 perl(warnings)
      1 perl-libs
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

$ rpm -q --provides -p 
../RPMS/noarch/perl-Crypt-SysRandom-0.007-1.fc44.noarch.rpm | sort -f | uniq -c
      1 perl(Crypt::SysRandom) = 0.007
      1 perl-Crypt-SysRandom = 0.007-1.fc44
Binary privides are Ok.

$ resolvedeps f44-build
../RPMS/noarch/perl-Crypt-SysRandom-0.007-1.fc44.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in Fedora 44
(https://koji.fedoraproject.org/koji/taskinfo?taskID=136532156). Ok.

This package is in line with Fedora and Perl packaging guidelines.
This package is APPROVED.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2387827

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202387827%23c2

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux