https://bugzilla.redhat.com/show_bug.cgi?id=2391313 --- Comment #4 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec review: > Name: bazaar I would prefer this package to be named "bazaar-store" simply to avoid confusion with the Bazaar VCS. This is not a firm requirement, but it also simplifies things if you're not reusing an existing package name (no unretirement process required). > Summary: A flatpak centered app store The summary can be tightened up a bit to follow rpmlint guidelines: "Flatpak-centric software center and app store" > Source0: %{url}/archive/refs/tags/v%{version}.tar.gz The SourceURL should be reformulated as "%{url}/archive/v%{version}/bazaar-%{version}.tar.gz" Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags > # https://github.com/kolunmi/bazaar/pull/275 > Patch: 275.patch This should be restructured to use a URL for the Patch line, and the comment should explain what the patch is for > Requires: glycin-libs > Requires: libadwaita > Requires: libsoup3 > Requires: json-glib What are these for? It looks like RPM already generates the required dependencies, so these should be dropped. > %description > A new app store for GNOME with a focus on discovering and installing applications and add-ons from Flatpak remotes, particularly Flathub. > It emphasizes supporting the developers who make the Linux desktop possible. > Bazaar features a "curated" tab that can be configured by distributors to allow for a more locallized experience. This needs to be wrapped to 79 columns. > %build > %meson > %meson_build The "%meson" call should be split into the "%conf" section unless you plan to ship it in EPEL < 10. See this as an example: https://src.fedoraproject.org/rpms/waynergy/blob/rawhide/f/waynergy.spec > %changelog > * Wed Aug 27 2025 Kyle Gospodnetich <me@xxxxxxxxxxxxxxxxx> > - Init package Changelog format is not quite right and needs version-release mentioned somewhere. Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/manual-changelog/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2391313 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202391313%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
