https://bugzilla.redhat.com/show_bug.cgi?id=2385892 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |code@xxxxxxxxxxxxxxxxxx CC| |code@xxxxxxxxxxxxxxxxxx Status|NEW |ASSIGNED --- Comment #1 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/numpy-0.25.0/CHANGELOG.md See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files This is not a serious problem; it is due to a reasonable design decision in rust2rpm. - The rust-numpy-devel has an unnecessary dependency on /usr/bin/python3 due to the executable development script x.py. Requires -------- rust-numpy-devel (rpmlib, GLIBC filtered): […] /usr/bin/python3 I opened an upstream PR https://github.com/PyO3/rust-numpy/pull/510 that will fix this in future releases. Meanwhile, you can do the same downstream: add [package] cargo-toml-patch-comments = [ """\ Exclude some unnecessary files from the crate \ (https://github.com/PyO3/rust-numpy/pull/510): \ avoids an unwanted dependency on the Python interpreter\ """, ] to rust2rpm.toml, and patch Cargo.toml (with rust2rpm -p) as follows: --- numpy-0.25.0/Cargo.toml 1970-01-01T00:00:01+00:00 +++ numpy-0.25.0/Cargo.toml 2025-09-01T18:32:46.706081+00:00 @@ -40,6 +40,12 @@ ] license = "BSD-2-Clause" repository = "https://github.com/PyO3/rust-numpy"; +exclude = [ + ".github/*", + ".gitignore", + "codecov.yml", + "x.py", +] [package.metadata.docs.rs] all-features = true - The latest version (0.26) is not packaged, but this makes since since the version needs to be aligned with the rest of the PyO3 stack, which is currently still at 0.25 in Fedora. - Three tests fail on i686 due to implicit 64-bit assumptions in the expected sizes and alignments in the tests. I explored fixing this in https://github.com/PyO3/rust-numpy/pull/511, but decided it was just not worth it after finding (via upstream CI) that the behavior is different on Windows. Unless you are willing to dig through this more thoroughly than I was, I suggest skipping these three tests, something like (in rust2rpm.toml): [scripts.check] pre = [ """\ %if 0%{?__isa_bits} == 32 # * Tests dtype::tests::test_dtype_methods_* fail on 32-bit (but not 32-bit # Windows, per upstream CI) because a few sizes and alignments are different # from the hard-coded expected values. We explored fixing this in # https://github.com/PyO3/rust-numpy/pull/511 but it’s just not worth it: we # skip the affected tests instead. %cargo_test -- -- --skip dtype::tests::test_dtype_methods_ %else\ """, ] post = [ "%endif", ] ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 2-Clause License". 38 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2385892-rust-numpy/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). The automatically-generated Requires: /usr/bin/python3 is correctly derived from the executable x.py script, but is not actually necessary and can be avoided. See Issues. [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- numpy-devel , rust-numpy+default-devel , rust-numpy+half-devel , rust- numpy+nalgebra-devel [x]: Package functions as described. (Tests pass) [!]: Latest version is packaged. Version 0.26 is available, but this must wait to be aligned with the rest of the PyO3 stack in Fedora. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [!]: Package should compile and build into binary rpms on all supported architectures. Three tests fail on i686 and need to be skipped; see Issues. [x]: %check is present and all tests pass. (except on i686) [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-numpy-devel-0.25.0-1.fc44.noarch.rpm rust-numpy+default-devel-0.25.0-1.fc44.noarch.rpm rust-numpy+half-devel-0.25.0-1.fc44.noarch.rpm rust-numpy+nalgebra-devel-0.25.0-1.fc44.noarch.rpm rust-numpy-0.25.0-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmprvsawj7f')] checks: 32, packages: 5 5 packages and 0 specfiles checked; 0 errors, 0 warnings, 25 filtered, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 4 packages and 0 specfiles checked; 0 errors, 0 warnings, 21 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/numpy/0.25.0/download#/numpy-0.25.0.crate : CHECKSUM(SHA256) this package : 29f1dee9aa8d3f6f8e8b9af3803006101bb3653866ef056d530d53ae68587191 CHECKSUM(SHA256) upstream package : 29f1dee9aa8d3f6f8e8b9af3803006101bb3653866ef056d530d53ae68587191 Requires -------- rust-numpy-devel (rpmlib, GLIBC filtered): (crate(libc/default) >= 0.2.0 with crate(libc/default) < 0.3.0~) (crate(ndarray/default) >= 0.15.0 with crate(ndarray/default) < 0.17.0~) (crate(num-complex/default) >= 0.2.0 with crate(num-complex/default) < 0.5.0~) (crate(num-integer/default) >= 0.1.0 with crate(num-integer/default) < 0.2.0~) (crate(num-traits/default) >= 0.2.0 with crate(num-traits/default) < 0.3.0~) (crate(pyo3) >= 0.25.0 with crate(pyo3) < 0.26.0~) (crate(pyo3-build-config/default) >= 0.25.0 with crate(pyo3-build-config/default) < 0.26.0~) (crate(pyo3-build-config/resolve-config) >= 0.25.0 with crate(pyo3-build-config/resolve-config) < 0.26.0~) (crate(pyo3/macros) >= 0.25.0 with crate(pyo3/macros) < 0.26.0~) (crate(rustc-hash/default) >= 2.0.0 with crate(rustc-hash/default) < 3.0.0~) /usr/bin/python3 cargo rust rust-numpy+default-devel (rpmlib, GLIBC filtered): cargo crate(numpy) rust-numpy+half-devel (rpmlib, GLIBC filtered): (crate(half) >= 2.0.0 with crate(half) < 3.0.0~) cargo crate(numpy) rust-numpy+nalgebra-devel (rpmlib, GLIBC filtered): (crate(nalgebra) >= 0.30.0 with crate(nalgebra) < 0.34.0~) cargo crate(numpy) Provides -------- rust-numpy-devel: crate(numpy) rust-numpy-devel rust-numpy+default-devel: crate(numpy/default) rust-numpy+default-devel rust-numpy+half-devel: crate(numpy/half) rust-numpy+half-devel rust-numpy+nalgebra-devel: crate(numpy/nalgebra) rust-numpy+nalgebra-devel Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2385892 Buildroot used: fedora-rawhide-aarch64 Active plugins: Generic, Shell-api Disabled plugins: fonts, SugarActivity, Java, Haskell, C/C++, Python, Perl, Ocaml, PHP, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2385892 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202385892%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
