https://bugzilla.redhat.com/show_bug.cgi?id=2391549 Cristian Le <fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxx Status|NEW |ASSIGNED --- Comment #2 from Cristian Le <fedora@xxxxxxxxx> --- Only 2 comments: - The `-t` is `generate_buildrequires` is unnecessary. The tox environment doesn't seem to have anything useful for us and it would be better to interact with `%pytest` directly if we will need to skip some tests (it did happen at one sphinx update that I was present for) - Instead of having to use `SETUPTOOLS_SCM_PRETEND_VERSION`, please use the pypi_source. Although it is odd because I do see there is a `.git_archival.txt` file present (in the old broken format, I'll make a PR to fix that), so the `SETUPTOOLS_SCM_PRETEND_VERSION` should not be needed in either way. Have you had a build failure around it, would be useful to investigate -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2391549 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202391549%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
