https://bugzilla.redhat.com/show_bug.cgi?id=2363088 --- Comment #17 from John Whitington <john@xxxxxxxxxxxxxxxxxxxxxx> --- Thanks. Here's the next attempt: Spec URL: https://coherentpdf.com/fedora4/ocaml-camlpdf.spec SRPM URL: https://coherentpdf.com/fedora4/ocaml-camlpdf-2.8.1-1.fc41.src.rpm Koji log: https://koji.fedoraproject.org/koji/taskinfo?taskID=136727055 1 The License field is still incomplete. The files pdfafmdata.ml and pdfafmdata.source.ml carry another license. SPDX calls this license APAFML. It is on the allowed list for Fedora. Done. 2 Please add a comment about the patch to the spec file Done. 3 Is there any possibility of doing some basic tests in a %check script? For example, could examples/* be used to do something simple, just to verify that the package works at all? Done. We build pdfhello.ml, run it to generate hello.pdf and see if the file exists. 4 Note the incorrect-fsf-address complaint from rpmlint below. Could you get that fixed upstream? The FSF now publishes license text that includes a web address instead of a street addess, for what it's worth: https://www.gnu.org/licenses/old-licenses/lgpl-2.1.html Done upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2363088 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202363088%23c17 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
