https://bugzilla.redhat.com/show_bug.cgi?id=2379742 --- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to wojnilowicz from comment #2) > I would like to review it, but currently it fails to build on f43 due to > #2379740. Thank you! Normally, packages are reviewed against a mock build for Rawhide, which is the default if you just run > fedora-review -b 2379742 If you need to review against F43 for some reason, you can pass --enablerepo=updates-testing to mock to get python-rignore, e.g.: > fedora-review -b 2379742 --mock-config=fedora-43-x86_64 --mock-options=--enablerepo=updates-testing but again, normally packages should be be reviewed against Rawhide. I do intend to ship this package for F43 once it passes review. If that happens soon enough, I’ll add it to the update https://bodhi.fedoraproject.org/updates/FEDORA-2025-b4d73ac41b. > Anyway, that's what I found so far: > 1) 0.1.4 is no longer the latest version. Looks like the changes in 0.1.5 are small, https://github.com/fastapilabs/fastapi-cloud-cli/compare/0.1.4...0.1.5. I’ll update the submission. > 2) Isn't the following line "%py_provides python3-fastapi-cloud-cli" added > by the build system already, or is the build system adding "%py_provides > python3-fastapi_cloud_cli" and the manually added line is indeed justified? Here is the difference it makes. With "%py_provides python3-fastapi-cloud-cli": $ rpm -q --provides -p results_fastapi-cloud-cli/0.1.4/1.fc44/fastapi-cloud-cli-0.1.4-1.fc44.noarch.rpm fastapi-cloud-cli = 0.1.4-1.fc44 python-fastapi-cloud-cli = 0.1.4-1.fc44 python3-fastapi-cloud-cli = 0.1.4-1.fc44 python3.14-fastapi-cloud-cli = 0.1.4-1.fc44 python3.14dist(fastapi-cloud-cli) = 0.1.4 python3dist(fastapi-cloud-cli) = 0.1.4 Without it: $ rpm -q --provides -p results_fastapi-cloud-cli/0.1.4/1.fc44/fastapi-cloud-cli-0.1.4-1.fc44.noarch.rpm fastapi-cloud-cli = 0.1.4-1.fc44 python3.14dist(fastapi-cloud-cli) = 0.1.4 python3dist(fastapi-cloud-cli) = 0.1.4 We can see that the python3*dist(fastapi-cloud-cli) Provides are there either way, since they are generated based on the .dist-info metadata. What %py_provides adds is the python3*-fastapi-cloud-cli “aliases.” These would already be done automatically if the package were named python3-fastapi-cloud-cli (https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_provides_for_importable_modules), but it’s named fastapi-cloud-cli because it functions primarily as an application (https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_application_naming), not as a library (https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_library_naming). Now, one might ask, is there any reason to bother with this, since the importable module appears to exist just to support the CLI tool? I wouldn’t say it’s necessary or mandatory to add %py_provides in a case like this (it’s only a SHOULD in the guidelines anyway). Still, I think there’s a good chance that some users may try "dnf install python3-fastapi-cloud-cli” by analogy to python3-fastapi. Adding %py_provides means that will still work, and doesn’t really have any obvious downsides. ---- Revisiting this submission, I’m finding that the tests have started producing some failures and errors. I believe everything was working fine when I submitted this, so either something changed in the dependencies or I missed some checks before uploading the original submission. I have almost identical testing issues in a git checkout, so I asked upstream about it in https://github.com/fastapilabs/fastapi-cloud-cli/discussions/76 and skipped the problematic tests for now. I also updated to 0.1.5. New Spec URL: https://music.fedorapeople.org/20250906/fastapi-cloud-cli.spec New SRPM URL: https://music.fedorapeople.org/20250906/fastapi-cloud-cli-0.1.5-1.fc42.src.rpm Thanks for looking at this! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2379742 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202379742%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
