https://bugzilla.redhat.com/show_bug.cgi?id=2388110 --- Comment #5 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Kai A. Hiller from comment #4) > Hi Ben, thank you for your time and the reviews! You’re welcome! ---- As with bug 2388113, the Cargo.toml metadata patch should have an explanatory comment of some sort (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_all_patches_should_have_an_upstream_bug_link_or_comment), even though it is nearly self-explanatory, and it should be possible to run a few of the tests. Also, the Summary is more than 80 characters, so you should override it manually in rust2rpm.toml. Something like the following should work. rust2rpm.toml: [package] summary = "Unicode line breaking and text segmentation algorithms" cargo-toml-patch-comments = [ "Omit benchmark-only dev-dependency on criterion", """\ Restore icu_properties dev-dependency (version 2.0), which was path-based and was therefore removed in Cargo.toml normalization.\ """, ] [tests] comments = [ """\ Very many doctests have circular dependencies on the top-level icu crate, \ enough that it would be very tedious to patch them all out.\ """, ] run = [ "lib", ] icu_segmenter-fix-metadata.diff --- icu_segmenter-2.0.0/Cargo.toml 1970-01-01T00:00:01+00:00 +++ icu_segmenter-2.0.0/Cargo.toml 2025-09-10T20:49:07.870146+00:00 @@ -172,6 +172,10 @@ ] default-features = false +[dev-dependencies.icu_properties] +version = "2.0.0" +features = ["compiled_data"] + [dev-dependencies.itertools] version = "0.14.0" @@ -182,6 +186,3 @@ [dev-dependencies.serde_json] version = "1.0.45" - -[target.'cfg(not(target_arch = "wasm32"))'.dev-dependencies.criterion] -version = "0.5.0" -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2388110 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202388110%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
