https://bugzilla.redhat.com/show_bug.cgi?id=2394287 --- Comment #3 from Scott K Logan <logans@xxxxxxxxxxx> --- Carl, thanks very much for picking up the review. > Based on the upstream README, this seems to be primarily an application, not a library. At present, this package is indeed only providing an application. However, we intend to use it to revive the python-bloom package, which was retired from Fedora when "python-vcstools" (the third and oldest of these vcs utilities) was retired over a year ago due to abandonment upstream. To do that, Bloom will interact with vcs2l as a Python library. > This package should also utilize %autorelease and %autochangelog. Sure, I didn't realize this was now a recommended practice in the packaging guidelines. > Upstream makes this easy by defining those in a "test" extra. Indeed, but it required some cleanup that has yet to be released. I was planning on making the switch in the next version. https://github.com/ros-infrastructure/vcs2l/pull/63 > It isn't useful to ship shell completions in /usr/share/vcs2l-completion. That's a genuine oversight. I'll find the right spot tomorrow morning and update the review. Thanks again for taking a look! --scott -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2394287 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202394287%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
