https://bugzilla.redhat.com/show_bug.cgi?id=2385892 --- Comment #4 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Alexander Lent from comment #2) > Spec URL: > https://gist.github.com/xanderlent/c3e9f79ff78a2a67353117bbb919a83d/raw/ > 549d9b52394f3b78eab93541a48c4fee9daa22c4/rust-numpy.spec > SRPM URL: > https://gist.github.com/xanderlent/c3e9f79ff78a2a67353117bbb919a83d/raw/ > 549d9b52394f3b78eab93541a48c4fee9daa22c4/rust-numpy-0.25.0-1.fc44.src.rpm Thanks. I’ll have a look at this as soon as I have a chance. > Thanks much for the cleanups, I've incorporated them verbatim. This remains > at version 0.25.0 due to missing pyo3 0.26. Do you have any other > suggestions for coordinating pyo3 stack maintenance like adding co-owners? Adding rust-sig with at least commit permissions should suffice. I mentioned this review to Fabio Valentini (decathorpe) on the Rust Matrix channel, so he’s aware that this package will be involved in future PyO3 updates. He will be the main person you’ll need to coordinate with for updates. > I'm not sure we'll need i686 given that the proposed downstream doesn't need > it (rust-tokenizers depends on rust-safetensors, which excludes i686) > especially if upstream is only designing for 64-bit. On one hand, other > folks might want this library later for other use cases, OTOH the trend in > Fedora is to eliminate i686 and 32-bit generally. True, you could get away without it in this case. However, since you can easily skip the failing tests on 32-bit architectures (and the tests fail due to a testing issue rather than a library bug), I would suggest doing that rather than adding ExcludeArch. It’s always nice to keep Rust library packages available on i686 when we can, because one never knows when an existing application package (that isn’t a leaf and can’t easily drop i686) will suddenly find a library has been pulled into its dependency tree. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2385892 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202385892%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
