https://bugzilla.redhat.com/show_bug.cgi?id=2376217 Maxwell G <maxwell@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? Assignee|steve.traylen@xxxxxxx |maxwell@xxxxxxx --- Comment #56 from Maxwell G <maxwell@xxxxxxx> --- Thanks. > %if ! 0%{?el8} > BuildRequires: go-rpm-macros > %endif - Remove the %if statement. go-rpm-macros is Provided by go-rpm-macros-epel on EPEL 8. You need to include this if you don't want to get the broken %gobuild definition without GO_BUILDTAGS support. > gzip -c bao.1 >%{buildroot}%{_datadir}/man/man1/bao.1.gz > ln -s bao.1 %{buildroot}%{_datadir}/man/man1/%{oldname}.1.gz - Please don't manually compress manpages. Install the uncompressed manpage and change > %{_datadir}/man/man1/bao.1.gz in %files to %{_mandir}/man1/bao.1* . Other than that, I think this is fine now. I'll approve it once those two changes are made. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2376217 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202376217%23c56 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
