https://bugzilla.redhat.com/show_bug.cgi?id=2302630 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|decathorpe@xxxxxxxxx |nobody@xxxxxxxxxxxxxxxxx Status|ASSIGNED |NEW Flags|fedora-review? | --- Comment #14 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- In Matrix chat, Fabio encouraged me to take over this review since he was short on time. The latest submission has the same LICENSE-APACHE as the upstream 0.2.0 crate, without the full license text. I think you wanted the contents of: https://github.com/oliver-giersch/tagptr/raw/81e5c6a5cbd86e0da1e47deb9ce134d1e5624137/LICENSE-APACHE Indeed, you could use the URL for that source, like: # * Missing license text, https://github.com/oliver-giersch/tagptr/pull/3 Source2: https://github.com/oliver-giersch/tagptr/raw/81e5c6a5cbd86e0da1e47deb9ce134d1e5624137/LICENSE-APACHE You will also need to actually copy the license file into the extracted crate, like: %prep %autosetup -n %{crate}-%{version} -p1 cp -p '%{SOURCE2}' . %cargo_prep You could do this in rust2rpm.toml with: [scripts.prep] pre = ["cp -p '%{SOURCE2}' ."] I don’t see any other obvious issues. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2302630 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202302630%23c14 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
