https://bugzilla.redhat.com/show_bug.cgi?id=2394974 Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mikel@xxxxxxxxxxxxxxx --- Comment #7 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- > %global go_ldflags -X %{goipath}/pkg/version.GITCOMMIT=%{release} > export GO_LDFLAGS="%{go_ldflags}" > (...) > export GO_LDFLAGS="%{go_ldflags}" would make more sense to just assign it to GO_LDFLAGS instead of doing it twice. Also, is required for the tests to have it assigned? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2394974 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202394974%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
