https://bugzilla.redhat.com/show_bug.cgi?id=2394974 --- Comment #8 from Brad Smith <bradley.g.smith@xxxxxxxxx> --- Many thanks Maxwell and Mikel. You comments improved the specfile. I created a docs subpackage. I often debate build and check settings in the spec file between following the upstream as, for example, defined in a Makefile or starting with the default settings for processing a golang project specfile. Not setting GO_LDFLAGS for check did not affect gotest results so I left it out in favour of simplicity. [fedora-review-service-build] -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2394974 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202394974%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue