[Bug 2394940] Review Request: SPIRV-Cross - SPIRV-Cross is a tool designed for parsing and converting SPIR-V to other shader languages.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2394940



--- Comment #4 from Anthony Oon <anthony.zh.oon@xxxxxxxxx> ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/a-zhn/ghostty-deps/fedora-42-x86_64/09554567-SPIRV-Cross/SPIRV-Cross.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/a-zhn/ghostty-deps/fedora-42-x86_64/09554567-SPIRV-Cross/SPIRV-Cross-1.4.321-1.fc42.src.rpm

> Is there a technical reason why the static (.a) libraries are absolutely necessary? If so, can you document it in the spec file? Otherwise, please pass -DSPIRV_CROSS_STATIC:BOOL=OFF to %cmake, disabling the static libraries.
The static libraries aren't necessary, but I do want to provide the CLI. 

> Is there a reason for this?
> # Remove cmake package files
> rm -r %{buildroot}/%{_datadir}

I don't have a reason to exclude them, just wasn't using them personally so
that's been changed.

Missed the detail about unversioned .so files, that should be fixed


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2394940

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202394940%23c4

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux