[Bug 2386079] Review Request: manifold - Geometry library for topological robustness

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2386079



--- Comment #8 from Benson Muite <benson_muite@xxxxxxxxxxxxx> ---
Comments:
a) Thanks for the updates.

b) Please use

ExcludeArch: i686

rather than listing architectures to be included.


c) An example with pytest and documentation is at:

https://copr.fedorainfracloud.org/coprs/fed500/manifold/build/9413161/

This builds the package twice as the Python package build is a little different
than the regular
build. Perhaps another way can be found to build the Python package metadata,
for example by
adding an option to the CMakeLists.txt files to build a Python wheel.

d) Maybe patches can be applied to clipper2 to enable shared versions of
clipper2utils to be built:
https://github.com/AngusJohnson/Clipper2/blob/main/CPP/CMakeLists.txt#L135
https://github.com/AngusJohnson/Clipper2/blob/main/CPP/CMakeLists.txt#L142
This is not blocking, but would be nice if possible at some point in future.

e) Consider reporting S390x test failure upstream:
https://koji.fedoraproject.org/koji/taskinfo?taskID=136040145


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2386079

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202386079%23c8

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux