https://bugzilla.redhat.com/show_bug.cgi?id=2376217 --- Comment #25 from Dave Dykstra <dwd@xxxxxxx> --- Maxwell: I'm no longer bundling the go toolchain, it's just that I think that there may be situations in the future in EPEL where it will be needed, when needed dependencies require a newer version than available in RHEL. We can consider that to be a separate issue, now tracked in https://pagure.io/fesco/issue/3464. The main problem with %gobuild is not that it isn't supported in EPEL8, it is that it doesn't support adding tags as far as I can tell, and openbao needs to add a tag. Do you know of a way to do it? There's also no way to add gcflags, although I only use those for optional debugging so they're not strictly required. There are a lot of ci checks done upstream with each PR. By unit tests, are you talking about testing individual source units that go into making openbao, or testing the openbao final binary "unit"? I assume it's the latter. I inquired about tests for that and was told that it's on their wish list but those kinds of release validation tests unfortunately do not yet exist. The package does already have a sysusers configuration. I removed the `systemctl daemon-reload`. I added an MIT-2.0 LICENSE file to the openbao-rpm repo, the same as the upstream. I understand that the spec file will need to be primarily sourced for Fedora & EPEL from the pkgs.fedoraproject.org git, but I'd like to be able to continue to use this as the source for the extra files if it is allowed. That way there's a single primary source for those extra files instead of a copy per fNN and epelN branch, and I can have github actions to test things before building on koji. I thought the latest iteration did have a License tag in a proper SPDX expression including the licenses of all the vendored packages, but I see now it is supposed to have `AND` as uppercase instead of lowercase. I made that change too. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2376217 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202376217%23c25 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
