https://bugzilla.redhat.com/show_bug.cgi?id=2387676 --- Comment #5 from Yaakov Selkowitz <yselkowi@xxxxxxxxxx> --- (In reply to Dominik 'Rathann' Mierzejewski from comment #2) > 1. Is there a good reason to use `-f` in the `rm` calls below? I'm wary of `rm -f` because it hides errors. e.g. if a future BRP would automate the removal of %_infodir/dir, there's no reason for that to trigger an error. (TBH I'm surprised such doesn't already exist.) > 2. You should patch lavtc.sh to avoid pointing to /usr/local/bin and rely on > $PATH, like Debian does: > https://sources.debian.org/patches/mjpegtools/1:2.1.0+debian-8.1/ > 10_usr_local.patch/ Added. > 3. Debian has a patch for this: > ... > %configure LIBS="-lpthread" \ > ... > https://sources.debian.org/patches/mjpegtools/1:2.1.0+debian-8.1/ > 06_link_pthread.patch/ This patch doesn't seem to make much sense, particularly nowadays in light of https://developers.redhat.com/articles/2021/12/17/why-glibc-234-removed-libpthread > 4. The GUI applications are so ancient it probably makes no sense to require > .desktop files for them. They are designed to be launched from the command line, so desktop files wouldn't help much. > 5. Likewise, it's probably not worth the effort to modernize the ancient m4 > macros used in configure script. Agreed. > Package APPROVED. Thanks for the review; waiting on branching to complete to add it. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2387676 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202387676%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
