https://bugzilla.redhat.com/show_bug.cgi?id=2387676 --- Comment #2 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- 1. Is there a good reason to use `-f` in the `rm` calls below? I'm wary of `rm -f` because it hides errors. ... rm -f %{buildroot}%{_infodir}/dir %if 0%{?rhel} && 0%{?rhel} < 10 rm -f %{buildroot}%{_libdir}/*.la %endif # too broken/outdated to be useful in 1.[89].0 (and would come with dep chain) rm -f %{buildroot}%{_bindir}/mpegtranscode # requires mencoder rm -f %{buildroot}%{_bindir}/lav2avi.sh ... 2. You should patch lavtc.sh to avoid pointing to /usr/local/bin and rely on $PATH, like Debian does: https://sources.debian.org/patches/mjpegtools/1:2.1.0+debian-8.1/10_usr_local.patch/ LGTM otherwise. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2387676 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202387676%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
