https://bugzilla.redhat.com/show_bug.cgi?id=2363933 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |jplesnik@xxxxxxxxxx Status|NEW |ASSIGNED CC| |jplesnik@xxxxxxxxxx Flags| |fedora-review? --- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires FIX: Add build-require 'coreutils' it is needed for %{_fixperms} FIX: Add build-require - perl(Config) - t/simple.t:4 $ rpm -qp --requires perl-Dist-Build-0.020-2.fc43.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Carp) 1 perl(CPAN::Meta) 1 perl(CPAN::Requirements::Dynamic) >= 0.002 1 perl(Dist::Build::Core) 1 perl(Dist::Build::Serializer) 2 perl(Exporter) >= 5.57 1 perl(ExtUtils::Builder::Action::Function) 1 perl(ExtUtils::Builder::Compiler) >= 0.028 1 perl(ExtUtils::Builder::Node) 2 perl(ExtUtils::Builder::Planner) >= 0.016 1 perl(ExtUtils::Builder::Planner::Extension) 1 perl(ExtUtils::Builder::Serializer) 1 perl(ExtUtils::Builder::Util) 1 perl(ExtUtils::Config) 1 perl(ExtUtils::Helpers) >= 0.007 2 perl(ExtUtils::Helpers) >= 0.028 1 perl(ExtUtils::Install) 1 perl(ExtUtils::InstallPaths) 1 perl(ExtUtils::Manifest) 1 perl(File::Basename) 1 perl(File::Copy) 1 perl(File::Find) 1 perl(File::Path) 1 perl(File::ShareDir::Tiny) 1 perl(File::Spec::Functions) 2 perl(Getopt::Long) >= 2.36 1 perl-libs 2 perl(List::Util) >= 1.33 1 perl(parent) 1 perl(Parse::CPAN::Meta) 1 perl(strict) 1 perl(Text::ParseWords) 1 perl(version) 1 perl(warnings) FIX: Please add run-requires: perl(CPAN::Meta::Merge) - lib/Dist/Build.pm:134 perl(CPAN::Requirements::Dynamic) - lib/Dist/Build/DynamicPrereqs.pm:17 perl(Perl::OSType) - lib/Dist/Build.pm:93 perl(Pod::Man) - lib/Dist/Build/Core.pm:309 perl(TAP::Harness::Env) - lib/Dist/Build/Core.pm:332 FIX: Please remove duplicit run-requires: perl(Exporter) >= 5.57 perl(ExtUtils::Builder::Planner) >= 0.016 perl(ExtUtils::Helpers) >= 0.028 perl(Getopt::Long) >= 2.36 perl(List::Util) >= 1.33 Otherwise binary requires are ok. $ rpm -qp --provides perl-Dist-Build-0.020-2.fc43.noarch.rpm | sort | uniq -c 1 perl(Dist::Build) = 0.020 1 perl-Dist-Build = 0.020-2.fc43 1 perl(Dist::Build::Core) = 0.020 1 perl(Dist::Build::DynamicPrereqs) = 0.020 1 perl(Dist::Build::Serializer) = 0.020 1 perl(Dist::Build::ShareDir) = 0.020 1 perl(Dist::Build::XS) = 0.020 1 perl(Dist::Build::XS::Alien) = 0.020 1 perl(Dist::Build::XS::Conf) = 0.020 1 perl(Dist::Build::XS::Export) = 0.020 1 perl(Dist::Build::XS::Import) = 0.020 1 perl(Dist::Build::XS::WriteConstants) = 0.020 Binary provides are Ok. $ rpmlint ./* Rpmlint is ok TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file. Resolution: NOT Approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2363933 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202363933%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
