https://bugzilla.redhat.com/show_bug.cgi?id=2363932 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? CC| |jplesnik@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |jplesnik@xxxxxxxxxx --- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires FIX: Add build-require 'coreutils' it is needed for %{_fixperms} FIX: Please add build-requires - perl(Config) - t/40-autodetect-executable.t:8 TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 NO_PACKLIST is provided since this version. $ rpm -qp --requires perl-ExtUtils-Builder-Compiler-0.031-2.fc43.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Carp) 1 perl(ExtUtils::Builder) >= 0.016 1 perl(ExtUtils::Builder::Action::Command) 1 perl(ExtUtils::Builder::ArgumentCollector) 1 perl(ExtUtils::Builder::AutoDetect::C) 1 perl(ExtUtils::Builder::Binary) 1 perl(ExtUtils::Builder::Compiler) 1 perl(ExtUtils::Builder::Linker) 1 perl(ExtUtils::Builder::Linker::COFF) 1 perl(ExtUtils::Builder::Linker::ELF::Any) 1 perl(ExtUtils::Builder::Linker::Unixy) 1 perl(ExtUtils::Builder::MultiLingual) 1 perl(ExtUtils::Builder::Node) 1 perl(ExtUtils::Builder::Planner) 1 perl(ExtUtils::Builder::Planner) >= 0.007 1 perl(ExtUtils::Builder::Planner::Extension) 1 perl(ExtUtils::Builder::Util) 2 perl(ExtUtils::Config) >= 0.007 2 perl(ExtUtils::Helpers) >= 0.027 1 perl(File::Basename) 1 perl(File::Spec::Functions) 1 perl(File::Temp) 1 perl-libs 1 perl(parent) 1 perl(Perl::OSType) 1 perl(sort) 1 perl(strict) 1 perl(warnings) FIX: Add run-require - perl(DynaLoader) - lib/ExtUtils/Builder/ParseXS.pm:72 FIX: Remove duplicit run-requires: - perl(ExtUtils::Config) >= 0.007 - perl(ExtUtils::Helpers) >= 0.027 Otherwise binary requires are Ok. $ rpm -qp --provides perl-ExtUtils-Builder-Compiler-0.031-2.fc43.noarch.rpm | sort | uniq -c 1 perl(ExtUtils::Builder::ArgumentCollector) = 0.031 1 perl(ExtUtils::Builder::AutoDetect::C) = 0.031 1 perl(ExtUtils::Builder::AutoDetect::Cpp) = 0.031 1 perl(ExtUtils::Builder::Binary) = 0.031 1 perl(ExtUtils::Builder::Compiler) = 0.031 1 perl-ExtUtils-Builder-Compiler = 0.031-2.fc43 1 perl(ExtUtils::Builder::Compiler::MSVC) = 0.031 1 perl(ExtUtils::Builder::Compiler::Unixy) = 0.031 1 perl(ExtUtils::Builder::Compiler::VMS) = 0.031 1 perl(ExtUtils::Builder::Conf) = 0.031 1 perl(ExtUtils::Builder::Linker) = 0.031 1 perl(ExtUtils::Builder::Linker::Ar) = 0.031 1 perl(ExtUtils::Builder::Linker::COFF) = 0.031 1 perl(ExtUtils::Builder::Linker::ELF::Any) = 0.031 1 perl(ExtUtils::Builder::Linker::ELF::GCC) = 0.031 1 perl(ExtUtils::Builder::Linker::Mach::GCC) = 0.031 1 perl(ExtUtils::Builder::Linker::PE::GCC) = 0.031 1 perl(ExtUtils::Builder::Linker::PE::MSVC) = 0.031 1 perl(ExtUtils::Builder::Linker::Unixy) = 0.031 1 perl(ExtUtils::Builder::Linker::XCOFF) = 0.031 1 perl(ExtUtils::Builder::MultiLingual) = 0.031 1 perl(ExtUtils::Builder::ParseXS) = 0.031 1 perl(ExtUtils::Builder::Profile::Perl) = 0.031 Binary provides are Ok. $ rpmlint ./perl-ExtUtils-Builder-Compiler* ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 8 filtered, 0 badness; has taken 0.2 s Rpmlint is ok TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file. Resolution: NOT Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2363932 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202363932%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
