https://bugzilla.redhat.com/show_bug.cgi?id=2363931 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |jplesnik@xxxxxxxxxx Flags| |fedora-review? CC| |jplesnik@xxxxxxxxxx --- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires FIX: Add build-require 'coreutils' it is needed for %{_fixperms} TODO: Please replace perl-blib by 'perl(blib)' TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 NO_PACKLIST is provided since this version. $ rpm -qp --requires perl-ExtUtils-Builder-0.017-2.fc43.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(base) 1 perl(Carp) 1 perl(Config) 2 perl(Exporter) >= 5.57 1 perl(ExtUtils::Builder::Action) 1 perl(ExtUtils::Builder::Action::Code) 1 perl(ExtUtils::Builder::Action::Command) 1 perl(ExtUtils::Builder::Action::Composite) 1 perl(ExtUtils::Builder::Action::Perl) 1 perl(ExtUtils::Builder::Action::Primitive) 1 perl(ExtUtils::Builder::FileSet) 1 perl(ExtUtils::Builder::FileSet::Filter) 1 perl(ExtUtils::Builder::FileSet::Free) 1 perl(ExtUtils::Builder::FileSet::Subst) 1 perl(ExtUtils::Builder::Node) 1 perl(ExtUtils::Builder::Plan) 1 perl(ExtUtils::Builder::Planner) 1 perl(ExtUtils::Builder::Util) 1 perl(ExtUtils::Config) 1 perl(ExtUtils::Config::MakeMaker) 2 perl(ExtUtils::MakeMaker) >= 6.68 1 perl(ExtUtils::Manifest) 1 perl(File::Basename) 1 perl(File::Spec) 1 perl(File::Spec::Unix) 1 perl-libs 2 perl(List::Util) >= 1.45 1 perl(parent) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Sub::Util) >= 1.40 1 perl(version) 1 perl(warnings) FIX: Please remove duplicit run-requires: - perl(Exporter) >= 5.57 - perl(ExtUtils::MakeMaker) >= 6.68 - perl(List::Util) >= 1.45 FIX: Please add run-requires - perl(Data::Dumper) - lib/ExtUtils/Builder/Action/Command.pm:19 - perl(Perl::OSType) - lib/ExtUtils/Builder/MakeMaker.pm:63 Otherwise binary requires are ok $ rpm -qp --provides perl-ExtUtils-Builder-0.017-2.fc43.noarch.rpm | sort | uniq -c 1 perl(ExtUtils::Builder) = 0.017 1 perl-ExtUtils-Builder = 0.017-2.fc43 1 perl(ExtUtils::Builder::Action) = 0.017 1 perl(ExtUtils::Builder::Action::Code) = 0.017 1 perl(ExtUtils::Builder::Action::Command) = 0.017 1 perl(ExtUtils::Builder::Action::Composite) = 0.017 1 perl(ExtUtils::Builder::Action::Function) = 0.017 1 perl(ExtUtils::Builder::Action::Perl) = 0.017 1 perl(ExtUtils::Builder::Action::Primitive) = 0.017 1 perl(ExtUtils::Builder::FileSet) = 0.017 1 perl(ExtUtils::Builder::FileSet::Filter) = 0.017 1 perl(ExtUtils::Builder::FileSet::Free) = 0.017 1 perl(ExtUtils::Builder::FileSet::Subst) = 0.017 1 perl(ExtUtils::Builder::MakeMaker) = 0.017 1 perl(ExtUtils::Builder::Node) = 0.017 1 perl(ExtUtils::Builder::Plan) = 0.017 1 perl(ExtUtils::Builder::Planner) = 0.017 1 perl(ExtUtils::Builder::Planner::Extension) = 0.017 1 perl(ExtUtils::Builder::Serializer) = 0.017 1 perl(ExtUtils::Builder::Util) = 0.017 Binary provides are Ok. $ rpmlint ./perl-ExtUtils-Builder* ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 8 filtered, 0 badness; has taken 0.3 s Rpmlint is ok TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists. E.g. %{_mandir}/man/ExtUtils::Builder* %{perl_vendorlib}/ExtUtils Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file. Resolution: NOT Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2363931 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202363931%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
