https://bugzilla.redhat.com/show_bug.cgi?id=2387563 --- Comment #6 from Pavel Raiskup <praiskup@xxxxxxxxxx> --- Spec URL: https://raw.githubusercontent.com/praiskup/norpm/refs/heads/main/python-norpm.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/praiskup/norpm-review/srpm-builds/09397166/python-norpm-1.2-1.src.rpm > Consider %autorelease, it is the preferred way for Fedora packages. TL;DR, I'd prefer staying with manual Release/%changelog. Long story... well you are not asking, so trying to not distract you. > Consider using https://github.com/praiskup/norpm instead, which is more useful to the users and more accurate as "the project URL". Fixed. > Please do run tests from https://github.com/praiskup/norpm/tree/main/tests or document the reasons for not doing so. Fixed. > I was surprised by %_bindir. Most of our packages use %{_bindir}: Yeah, I prefer to make the syntax simpler, and use curly brackets only if necessary (like with shell's `$foobar` vs `${foo}bar`. > Obviously, this is opinionated, but readability counts. +1 for readability. The pyp2spec generated few of {} for me, so I just made the current spec file consistent. > Why do the files have shebangs at all? Fixed. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2387563 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202387563%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
