https://bugzilla.redhat.com/show_bug.cgi?id=2387563 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx --- Comment #4 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Spec sanity: > Release: 1%{?dist} Consider %autorelease, it is the preferred way for Fedora packages. > URL: https://pypi.org/project/norpm/ Consider using https://github.com/praiskup/norpm instead, which is more useful to the users and more accurate as "the project URL". > %check > %pyproject_check_import Please do run tests from https://github.com/praiskup/norpm/tree/main/tests or document the reasons for not doing so. > %_bindir/norpm-expand-specfile I was surprised by %_bindir. Most of our packages use %{_bindir}: $ rg -lF '%_bindir' | wc -l 84 $ rg -lF '%{_bindir}' | wc -l 8747 Obviously, this is opinionated, but readability counts. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2387563 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202387563%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
