https://bugzilla.redhat.com/show_bug.cgi?id=2387291 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(benson_muite@emai | |lplus.org) | --- Comment #8 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- (In reply to Tomi Lähteenmäki from comment #7) > b) Was this needed even if upstream already run `appstreamcli validate > --nonet` [1]? From comment a) Koji build it can be seen the test is ran [2] > as it prints "2/2 Validate appstream file OK" Missed this, thanks for pointing it out. Would add BuildRequires: libappstream-glib to be sure it is available. Would then add a fedora specific patch to change https://gitlab.gnome.org/World/Phosh/phosh-tour/-/blob/main/data/meson.build?ref_type=heads#L42 from appstream_util = find_program('appstreamcli', required: false) to appstream_util = find_program('appstreamcli', required: true) to be sure it is run. Alternatively, remove it from the meson.build file and run it in the check section using appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/*.metainfo.xml > c) I'll add the %postun. Ok. > > [1] > https://gitlab.gnome.org/World/Phosh/phosh-tour/-/blob/v0.47.0/data/meson. > build?ref_type=tags#L44 > [2] https://kojipkgs.fedoraproject.org//work/tasks/2200/135852200/build.log -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2387291 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202387291%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
