https://bugzilla.redhat.com/show_bug.cgi?id=2386079 --- Comment #5 from Luya Tshimbalanga <luya_tfz@xxxxxxxxxxxxxxxx> --- (In reply to Benson Muite from comment #4) > > Comments: > a) Python package from PyPI also contains > manifold3d-3.2.1.dist-info > should this also be in the python package? Possibly but I'm unsure how to add that source file as the guideline (https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_empty_spec_file) is unclear. I renamed the subpackage as python3-manifold3d. > b) svd.h is under MIT license > https://github.com/elalish/manifold/blob/master/src/svd.h LICENSE line is updated in addition of Zlib according to licensecheck.txt. > c) Maybe good to test the python bindings: > https://github.com/elalish/manifold/blob/master/.github/workflows/manifold. > yml#L66 Unsure how to properly implement into %check as %pytest failed Updated SPEC: https://download.copr.fedorainfracloud.org/results/@designsuite/blender/fedora-rawhide-x86_64/09393314-manifold/manifold.spec SRPM: https://download.copr.fedorainfracloud.org/results/@designsuite/blender/fedora-rawhide-x86_64/09393314-manifold/manifold-3.2.1-1.fc43.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2386079 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202386079%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
