https://bugzilla.redhat.com/show_bug.cgi?id=2385991 --- Comment #2 from Dridi Boukelmoune <dridi.boukelmoune@xxxxxxxxx> --- Apologies for coming back later than I'd hoped, my spare time was scarcer than anticipated. > Can the spec file be modified to conditionally run the slow tests? I let the XXX comment and eventually forgot about it, but that was my intention. > Can the spec file be modified to produce a macro package first, thereby allowing for a two stage bootstrap? > > It is helpful to be able to run the review tool when updating, not just on initial import. I don't dispute the value of recurring reviews of a package, since packaging guidelines are a moving target. I'm reluctant to the idea of introducing a bootstrap step in the process. I made some effort to enable automatic dependency management and managed to upstream all the changes needed to support that. I added a hare-filesystem sub-package for a SHOULD NOT entry in the guidelines, at the expense of potentially running dependency generator more than once (not changing the final results). If I'm spending time on this fedora-review problem, I'd rather take it the other way around and teach it to parse the spec with sources. For example with the -r option since the spec is extracted alongside other sources in an srpm-unpacked directory. It is unfortunate that fedora-review fails in the presence of a %load macro, but I'd rather keep it and optimize for maintenance rather than review (or fix fedora-review). If the ruby package was submitted today, it would run into the same problem. It's probably possible to kick-start an automated review by manually expanding the %load macro in a copy of the spec, to get the initial template and supported checks. It's just not a seamless 'fedora-review -b 2385991` invocation. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2385991 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202385991%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
