https://bugzilla.redhat.com/show_bug.cgi?id=2373124 --- Comment #4 from Göran Uddeborg <goeran@xxxxxxxxxxx> --- Thanks a lot for your review! You probably realised, but just in case: the discrepancy in the spec file name, with and without version number, was just because I wanted to keep the original version available during the review if anyone wanted to compare. It is without version number in the SRPM and the repo. About your comments a) Yes, a good idea. b) and e) That I missed. I wonder if that really is intentional. The whole thing was recently relicensed to BSD-2-Clause recently. I'll update the spec, and also check with Marcus if it might be a mistke: https://github.com/portsentry/portsentry/issues/159 c) Nothing to comment, right? d) I already am in contact with him, he knows this work is ongoing. f) Good question, I was thinking about that but wasn't sure what to do. Portsentry can be run in various modes, it can just log, it can block itself, or it can integrate with fail2ban. See the top of the README. Thus a hard requirement seemed inappropriate. Perhaps a "recommends" would be better? Or maybe the fail2ban configuration files should be factored out in a separate (small) subpackage, that does require fail2ban? I chose the recommends option for now, but am open to ideas. What do you think? A new version, where I've also upgraded to the most recent upstreams version 2.0.3, is available at Spec URL: https://www.uddeborg.se/portsentry/portsentry-2.0.3.spec SRPM URL: https://www.uddeborg.se/portsentry/portsentry-2.0.3-1.fc43.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2373124 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202373124%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
