https://bugzilla.redhat.com/show_bug.cgi?id=2372339 --- Comment #5 from Simone Caronni <negativo17@xxxxxxxxx> --- @pavel.androniychuk@xxxxxxxxx please adjust the following: > %{_libdir}/libigsc.so.* Do not use wildcards here, in case there is a dependent package using the libraries, we want to avoid accidental shared object version bumps. > %{_libdir}/cmake/igsc/*.cmake Nothing owns the %{_libdir}/cmake/igsc folder. Please just use this to own all cmake files: %{_libdir}/cmake/igsc/ > %{_docdir} Your package does not own the entire _docdir, please own only the package folder. For example: %{_docdir}/%{name} I agree with the suggestion of using a separate doc package, the documentation is too big for the -devel subpackage. Please remember to include the %license tag also there, if the package will not require the base package in its chain of dependencies. > %{_mandir} Same as above, please own only your files, for example: %{_mandir}/man3/* > Requires: intel-gsc Please be more specific for the requirement, for example: Requires: %{name}%{?_isa} = %{version}-%{release} The same goes for the other requirements (intel-metee etc.) please use the same format with %{?_isa}. > BuildRequires: gcc gcc-c++ Please put BuildRequires each on its own line (not required, but definitely more readable). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2372339 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202372339%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
