https://bugzilla.redhat.com/show_bug.cgi?id=2386078 --- Comment #2 from Luya Tshimbalanga <luya_tfz@xxxxxxxxxxxxxxxx> --- (In reply to Benson Muite from comment #1) > Comments: > a) Please make a separate static sub-package > https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static- > libraries > Fixed. I will update the dependency on manifold package which requires it. > b) Consider adding %forgemeta macro and using %forgesource and %forgesetup > macros > https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > #_using_forges_hosted_revision_control Both %forgesoure and %forgesetup are useless due to the way upstream set up the source tarball. > > c) Please add he first part of the soname to the shared library listings > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shared_libraries > Fixed by adding "1{,*}" for both soname files > d) Please remove > # Install license to standard location > install -D -m 644 LICENSE -t %{buildroot}%{_licensedir}/%{name} > and replace > %license %{_licensedir}/%{name}/LICENSE > by > %license LICENSE > Dpme. > e) Consider adding > %doc README.md > to the main package > Included for both main and devel subpackages. > f) Why not build the documentation and run the tests by default? > Documentation can be > shipped in a subpackage, so one does not need to install it if one does not > want to. > Documentation built fine but the run tests failed upstream. > g) Some of the tests fail: > https://koji.fedoraproject.org/koji/taskinfo?taskID=135599414 > Reported upstream, https://github.com/AngusJohnson/Clipper2/issues/1001 > Maybe disable the failing tests for now, but run the other tests. > Test disabled by default. > h) Keep description lines to at most 80 characters in width. Fixed by limiting the lines at 80 characters. Here is the updated SPEC: https://download.copr.fedorainfracloud.org/results/@designsuite/blender/fedora-rawhide-x86_64/09366438-clipper2/clipper2.spec SRPM: https://download.copr.fedorainfracloud.org/results/@designsuite/blender/fedora-rawhide-x86_64/09366438-clipper2/clipper2-1.5.4-1.fc43.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2386078 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202386078%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
