https://bugzilla.redhat.com/show_bug.cgi?id=2373128 --- Comment #8 from Neal Gompa <ngompa13@xxxxxxxxx> --- Spec review notes: > # O/P added for 13.1 > Obsoletes: %{name}-service < %{version}-%{release} > Provides: %{name}-service = %{version}-%{release} This should be dropped as it's not relevant to us. > pushd selinux > make install DESTDIR=%{buildroot} > popd This can be replaced with "%make_install -C selinux" As for the changelog, it needs to have all of its entries sorted in reverse chronological order. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2373128 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202373128%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue