https://bugzilla.redhat.com/show_bug.cgi?id=2291284 --- Comment #15 from U2FsdGVkX1@xxxxxxxxx --- (In reply to Jerry James from comment #14) > For the purpose of educating both the submitter and the reviewer, here are a > few things to look for in future reviews. It is hard to convey tone in > electronic communications, so I want to stress that I am attempting to > educate, not criticize. > > First, "%global debug_package %{nil}" is both unnecessary and wrong. See > https://docs.fedoraproject.org/en-US/packaging-guidelines/Debuginfo/. That > line can and should be removed, since the -g flag is passed to both ocamlc > and ocamlopt during the build. > > Second, the spec contains "BuildRequires: ocaml-rpm-macros", but none of the > RPM macros defined in that package are actually used. If there is reason > not to use them, then this dependency should be removed. > > Third, the use of %attr in %files seems dodgy. Why do the files have wrong > permissions in the first place? It appears that the lem tool itself is > setting the incorrect permission bits. If I remove the built files in the > isabelle-lib directory and run this command: > > ../lem -isa -outdir ../isabelle-lib -wl ign -wl_auto_import err -wl_rename > err bool.lem basic_classes.lem function.lem maybe.lem num.lem tuple.lem > list.lem either.lem set_helpers.lem set.lem map.lem relation.lem sorting.lem > function_extra.lem assert_extra.lem list_extra.lem string.lem num_extra.lem > map_extra.lem set_extra.lem maybe_extra.lem string_extra.lem word.lem > show.lem show_extra.lem machine_word.lem pervasives.lem pervasives_extra.lem > debug.lem -auxiliary_level none -only_changed_output > > then the files are generated with the incorrect permissions. In > src/process_file.ml, lines 90-92 read: > > let open_output_with_check dir file_name = > let (temp_file_name, o) = Filename.open_temp_file "lem_temp" "" in > (o, (o, temp_file_name, Filename.concat dir file_name)) > > and the documentation of open_temp_file > (https://ocaml.org/manual/5.3/api/Filename.html) says: "The file is created > with permissions perms (defaults to readable and writable only by the file > owner, 0o600)." So this could be fixed by passing "~perms:0o666" to > open_temp_file. This should probably be discussed with lem upstream. > > Finally, I see several instances of this warning in the build log: > > Alert ocaml_deprecated_auto_include: > OCaml's lib directory layout changed in 5.0. The str subdirectory has been > automatically added to the search path, but you should add -I +str to the > command-line to silence this alert (e.g. by adding str to the list of > libraries in your dune file, or adding use_str to your _tags file for > ocamlbuild, or using -package str for ocamlfind). > > Please tell upstream that "use_str" needs to be added to src/_tags or the > package will stop building in some future OCaml release. > > I missed this package when rebuilding all Fedora OCaml packages this > weekend, so I will take care of #1 and #2 when I rebuild. Thank you for your guidance, and apologies for the late reply. I’ll look into how to address these issues. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2291284 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202291284%23c15 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
