https://bugzilla.redhat.com/show_bug.cgi?id=2379712 --- Comment #5 from Nils Philippsen <nphilipp@xxxxxxxxxx> --- (In reply to Akashdeep Dhar from comment #3) > > - You shouldn’t need to hardcode the path to the tesseract binary (in > > gi_loadouts/conf.py), pytesseract will use “tesseract” in $PATH per default. > > Addressed. Please check > https://github.com/gridhead/gi-loadouts/blob/ > d85abe2b99add1fb34c461b971ab1158a01279fd/gi_loadouts/conf.py. > > Also, as this is a cross-platform software application including Microsoft > Windows and MacOS (Yep) - It kinda has to be like that. I think you could make setting it conditional of the platform, but this exceeds the scope of a package review. One thing: I’m not sure if `shutil.which("tesseract")` would find `tesseract.exe` on Windows. > > - Why does the RPM package use a custom tarball, what’s the difference to the > > one not named `-custom`? > > Loadouts for Genshin Impact makes use of PySide6-Essentials, which is a > minimal package of PySide6. This however is not packaged on Fedora Linux and > hence, I have to resort to using the big PySide6 instead which is. The > custom tarball changes just that and nothing else. If there would be a way > to modify an existing tarball to make the aforementioned changes to it > before it is used for generating an SRPM, that would be a whole lot wieldier. Tricky 😉. I think the fault lies with how pyside6 is packaged in Fedora, essentially it includes pyside6-essentials and should carry the respective provides. You could work around it by having both pyside6 and pyside6-essentials as optional dependencies with corresponding extras, but this is also much hassle for little return. > > gi-loadouts.noarch: E: spelling-error ('gameplay', '%description -l en_US gameplay -> game play, game-play, gamely') > > gi-loadouts.src: E: spelling-error ('gameplay', '%description -l en_US gameplay -> game play, game-play, gamely') > > > > * False positive, both Oxford English Dictionary and Merriam Webster know this word > > I hate just how this is termed as an error. It should be a warning at best. > What's next then? My name gets termed as a typo? I think these speling errors are mostly useless, too. 🤷 > Actually, never mind - I actually do not care about making the RPM lint tool > happy anymore. 😁 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2379712 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202379712%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
