https://bugzilla.redhat.com/show_bug.cgi?id=2381771 --- Comment #3 from blinxen <h-k-81@xxxxxxxxxxx> --- > 1. You adapt the License tag in the spec file, but not in Cargo.toml. This will only have a local effect and not propagate to dependent packages that use the `%cargo_license*` macros. You need to patch Cargo.toml for it to have a global effect. I added a patch to update the license field in the "Cargo.toml" file. > 2. It looks like not all of icu is bundled (as you mentioned) - looking at the files that are included, they all seem to have a Unicode license header, and none with BSD-2/3-Clause or Public Domain dedications. Can you double-check whether you can drop those SPDX identifiers from the License tag? It would simplify things. You are right, I checked again and it seems tree-sitter is only using "Unicode-DFS-2016" licensed files from the ICU repository. Links to the updated files: Spec URL: https://blinxen.fedorapeople.org/rust-tree-house-bindings/rust-tree-house-bindings.spec SRPM URL: https://blinxen.fedorapeople.org/rust-tree-house-bindings/rust-tree-house-bindings-0.2.1-1.fc43.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2381771 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202381771%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
