https://bugzilla.redhat.com/show_bug.cgi?id=2381594 Xavier Bachelot <xavier@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Status|NEW |ASSIGNED --- Comment #3 from Xavier Bachelot <xavier@xxxxxxxxxxxx> --- - Source0 change is to bring more stability to the url, which could otherwise change with a new maintainer. - BR: coreutils is to make sure chmod is available in the buildroot. - weaver.ini does not bring any valuable information to the user. - Files section change are to avoid too wide globing, which is mentioned in the guidelines at https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions Combining with the perl guidelines to own the directories gives what I suggested. Formal review follows in a few. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2381594 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202381594%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
