https://bugzilla.redhat.com/show_bug.cgi?id=2381594 Xavier Bachelot <xavier@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xavier@xxxxxxxxxxxx --- Comment #1 from Xavier Bachelot <xavier@xxxxxxxxxxxx> --- Hi Shlomi, Some notes after taking a first look: - It's is usually preferred to reference the tarball by module rather than by author. Source0 could be changed to use https://cpan.metacpan.org/modules/by-module/File/File-ShouldUpdate-%{version}.tar.gz - Add BR: coreutils for _fixperms macro which uses chmod - Femove weaver.ini from %%doc - Files section could use less wildcards: %{perl_vendorlib}/File/ %{_mandir}/man3/File::ShouldUpdate.3pm* Regards, Xavier -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2381594 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202381594%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
