https://bugzilla.redhat.com/show_bug.cgi?id=2360688 Xavier Bachelot <xavier@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xavier@xxxxxxxxxxxx --- Comment #2 from Xavier Bachelot <xavier@xxxxxxxxxxxx> --- - It's is usually preferred to reference the tarball by module rather than by author. Source0 could be changed to use https://cpan.metacpan.org/modules/by-module/Mail/Mail-ListDetector-%{version}.tar.gz - add BR: coreutils for _fixperms macro which uses chmod - in files section, listing could be much simpler: """ %{_mandir}/man3/Mail::ListDetector*.3pm* %{perl_vendorlib}/Mail/ %{perl_vendorlib}/auto/Mail/ """ - BuildRequires needs to be checked, some compile and runtime BRs seem to be missing. Tangerine may help. Missing : AutoLoader (compile) Exporter (runtime) FileHandle (test) strict (compile) vars (compile) warnings (compile) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2360688 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202360688%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
