[Bug 2381956] Review Request: ocaml-crowbar - Code fuzzer for OCaml

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2381956



--- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> ---
(In reply to Richard W.M. Jones from comment #1)
> I notice the VCS URL in both packages is "git:https://...";.  I suppose we
> don't
> use this for anything, but unclear if that's correct or not.

I believe it matches the description of that tag here:
https://rpm.org/docs/4.19.x/manual/tags.html, in the table named "Informative
package tags".  As you say, nothing seems to actually use it.  It's just to
convey information to humans looking at a package, I think.

(In reply to Richard W.M. Jones from comment #2)
> Ocaml:
> [x]: This should never happen

One of these days I'm going to figure out why fedora-review does this.

> The undefined-non-weak-symbol errors are strange, but if the package
> works then it works.  It could be a problem in rpmlint or a
> peculiarity of OCaml.

The latter, I think.  Some of those symbols are provided by the OCaml runtime,
others by ocaml-cmdliner.  OCaml loads the dependencies first, so all symbols
should be defined when crowbar.cmxs is loaded.

Thank you for the review!


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2381956

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202381956%23c4

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux