https://bugzilla.redhat.com/show_bug.cgi?id=2350111 --- Comment #15 from Graham Leggett <minfrin@xxxxxxxx> --- (In reply to Jerry James from comment #14) > The URL given in the spec file, https://redwax.eu/rs/, does not work for me. > DNS can't resolve the name redwax.eu. Do you know what's going on? (See the > first SHOULD item below.) Perfect timing - we're currently experiencing a DNS outage, I am chasing. > There is no changelog entry for version 1.0.0. I encourage you to use > %autorelease and %autochangelog, which prevents such things from happening. > See https://docs.pagure.org/fedora-infra.rpmautospec/. I have enabled autorelease, alas autochangelog appears to be git only (our git is a mirror, the primary is svn). > I'm curious why the gpgverify step is commented out. Can you comment on > that? I've commented that back in. > FYI, there is an RPM macro %bash_completions_dir which you could use for > brevity. See /usr/lib/rpm/macros.d/macros.shell-completions. This is fixed. > Is there any possibility of including a %check script that does something > simple, such as convert a certificate from one format to another? Just > something to verify the program runs at all. I've added a %check that verifies the certificates for redwax.eu by way of example. > A scratch build > (https://koji.fedoraproject.org/koji/taskinfo?taskID=135087518) > shows that the package fails to build on 32-bit x86, because apr_time_t and > time_t are not the same size. That is okay, as we don't want to add more > 32-bit x86 packages anyway. Please add something like this to your spec > file: > > # See https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval > ExcludeArch: %{ix86} This is done. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2350111 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202350111%23c15 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue