https://bugzilla.redhat.com/show_bug.cgi?id=2364625 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #5 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- The package is approved, with a suggestion to better document the Cargo.toml patch. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec is generated by rust2rpm, greatly simplifying the review. Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/virtual- terminal-0.1.4/LICENSE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files OK; this is not a serious problem and is due to reasonable design decisions in rust2rpm. - It would be better to add a spec-file comment explaining what the Cargo.toml patch does and why, https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatus/. You could use a rust2rpm.toml like this: [package] cargo-toml-patch-comments = [ "Allow rustix-openpty 0.1, until 0.2 reaches stable in all stable releases", ] The result would be: # Manually created patch for downstream crate metadata changes # * Allow rustix-openpty 0.1, until 0.2 reaches stable in all stable releases Patch: virtual-terminal-fix-metadata.diff ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 9 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/20250720/2364625-rust-virtual- terminal/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- virtual-terminal-devel , rust-virtual-terminal+default-devel [?]: Package functions as described. The crate contains no tests that can be run when building the package. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. As noted in Issues, the Cargo.toml patch should have a comment explaining what it does and why it does it. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=135067760 [x]: %check is present and all tests pass. The %check section is correctly implemented, but the crate contains no tests that can be run. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) OK: differences are due solely to expansion of rpmautospec macros. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: rust-virtual-terminal-devel-0.1.4-1.fc43.noarch.rpm rust-virtual-terminal+default-devel-0.1.4-1.fc43.noarch.rpm rust-virtual-terminal-0.1.4-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpskde23vb')] checks: 32, packages: 3 3 packages and 0 specfiles checked; 0 errors, 0 warnings, 13 filtered, 0 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 9 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/virtual-terminal/0.1.4/download#/virtual-terminal-0.1.4.crate : CHECKSUM(SHA256) this package : 22d05fcc9d883c60c84a8f36c5a53ce5d5bb92e64a2ee2702bab98db2ac7c778 CHECKSUM(SHA256) upstream package : 22d05fcc9d883c60c84a8f36c5a53ce5d5bb92e64a2ee2702bab98db2ac7c778 Requires -------- rust-virtual-terminal-devel (rpmlib, GLIBC filtered): (crate(async-channel/default) >= 2.3.0 with crate(async-channel/default) < 3.0.0~) (crate(bmart/default) >= 0.2.11 with crate(bmart/default) < 0.3.0~) (crate(libc/default) >= 0.2.0 with crate(libc/default) < 0.3.0~) (crate(rustix-openpty/default) >= 0.1.0 with crate(rustix-openpty/default) < 0.3.0~) (crate(rustix/default) >= 1.0.0 with crate(rustix/default) < 2.0.0~) (crate(serde/default) >= 1.0.0 with crate(serde/default) < 2.0.0~) (crate(serde/derive) >= 1.0.0 with crate(serde/derive) < 2.0.0~) (crate(tokio/default) >= 1.0.0 with crate(tokio/default) < 2.0.0~) (crate(tokio/rt) >= 1.0.0 with crate(tokio/rt) < 2.0.0~) cargo rust-virtual-terminal+default-devel (rpmlib, GLIBC filtered): cargo crate(virtual-terminal) Provides -------- rust-virtual-terminal-devel: crate(virtual-terminal) rust-virtual-terminal-devel rust-virtual-terminal+default-devel: crate(virtual-terminal/default) rust-virtual-terminal+default-devel Diff spec file in url and in SRPM --------------------------------- --- /home/ben/fedora/review/20250720/2364625-rust-virtual-terminal/srpm/rust-virtual-terminal.spec 2025-07-20 20:56:44.680599981 -0400 +++ /home/ben/fedora/review/20250720/2364625-rust-virtual-terminal/srpm-unpacked/rust-virtual-terminal.spec 2025-05-06 20:00:00.000000000 -0400 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.7.3) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + # Generated by rust2rpm 27 %bcond check 1 @@ -68,3 +78,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Wed May 07 2025 John Doe <packager@xxxxxxxxxxx> - 0.1.4-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2364625 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: R, Java, Ocaml, C/C++, Perl, SugarActivity, fonts, Haskell, Python, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2364625 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202364625%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
