https://bugzilla.redhat.com/show_bug.cgi?id=2376217 --- Comment #13 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- > The official sources are included in Source1. then use the official source > I'm not using them directly because of the koji requirement to not do any internet accesses during build. They would be part of the srpm package or downloaded as any other source package, what's the problem? > There are some initial steps to the compilation process that do require internet access, and those are done during in the make-source-tarball script. It should be possible to remove the original sources from that tarball and have the %prep step recombine them, but it would be a hassle because the additional files are scattered throughout the source tree. Is it required? I would probably have it remove all the non-directories in the output of `tar tf` on the original source tarball. I understand that `make-source-tarball` prepares the system to run `make bootstrap && make static-dist && make prep`. - bootstrap: it mentions they're extra tools for developers. Is it required in the Fedora & EPEL context? - static-dist: can't upstream release the UI bits as part of the release? - prep: "runs `go generate` to build the dynamically generated source files.". Cant these also be part of the release or during %prep? Use the official source tarball and create another one with the generated bits, but discuss with upstream the possibility of the inclusion of the extra bits as part of the release. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2376217 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202376217%23c13 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
