https://bugzilla.redhat.com/show_bug.cgi?id=2379712 Nils Philippsen <nphilipp@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|benson_muite@xxxxxxxxxxxxx |nphilipp@xxxxxxxxxx --- Comment #1 from Nils Philippsen <nphilipp@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. Note: Unversionned Python dependency found. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Python/#_dependencies - Dist tag is present. * The dist tag should be optional, i.e. instead of “%{dist}”, use “%{?dist}”. Comments/Questions: =================== - You shouldn’t need to hardcode the path to the tesseract binary (in gi_loadouts/conf.py), pytesseract will use “tesseract” in $PATH per default. - Besides being 4 letters long and an uncommon abbreviation 😉, the %pack macro just introduces another level of indirection. You can just use “Name: gi-loadouts” and %name later. - %srce also is an uncommon way of shortening “source” and besides that, Python packages in Fedora usually use %srcname or %pypi_name for this purpose. You can also generate it automatically from %name instead of setting it manually: %global srcname %(echo %name | sed -e 's/-/_/g') - %uuid is a misnomer, org.gridhead.gi-loadouts isn’t a UUID[1]. I guess something like %app_id (à la [2]) would be more apt. Also, isn’t your domain gridhead.net rather than .org? [1]: https://en.wikipedia.org/wiki/Universally_unique_identifier [2]: https://docs.flatpak.org/en/latest/using-flatpak.html#identifiers - Why does the RPM package use a custom tarball, what’s the difference to the one not named `-custom`? ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.14, /usr/lib/python3.14/site-packages, /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor/scalable * The Python directories probably are false positives because I ran fedora-review on F42 (with Python 3.13 as the main version). * Most packages shipping hicolor icons just require hicolor-icon-theme which owns the icon directories. [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. * Links in the RPM changelog are too much detail, from the Packaging Guidelines[3]: “The changelog describes the changes to the package that are relevant to the users of the package.” In a new package, this is usually something like “Import [version XYZ as] new package” or similar. [3]: https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. * "tesseract": python3-pytesseract should require this (it doesn’t because the “Requires” line is in the wrong place, a fix is on the way) * From the Python Packaging Guidelines[4]: “Packages MUST NOT have dependencies (either build-time or runtime) with the unversioned prefix python- if the corresponding python3- dependency can be used instead.” * "python-pyside6": It should be sufficient if you added it as a python-level dependency to pyproject.toml * "python-pillow-qt": Ideally, the same should be true, but upstream doesn’t declare a “qt” extra for the pillow package => make it “python3-pillow-qt”. [4]: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_dependencies [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 29019 bytes in 1 files. [!]: Package complies to the Packaging Guidelines * This is sort of an umbrella for all the other items. Not sure why the template lists it at all, not to mention in the middle of all the other detailed things. 🤔 [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). * See “python-*” vs. “python3-*” above. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: gi-loadouts-0.1.9-1.fc43.noarch.rpm gi-loadouts-0.1.9-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmplxh75lyc')] checks: 32, packages: 2 gi-loadouts.noarch: E: spelling-error ('gameplay', '%description -l en_US gameplay -> game play, game-play, gamely') gi-loadouts.src: E: spelling-error ('gameplay', '%description -l en_US gameplay -> game play, game-play, gamely') * False positive, both Oxford English Dictionary and Merriam Webster know this word gi-loadouts.noarch: W: python-leftover-require python-pillow-qt gi-loadouts.noarch: W: python-leftover-require python-pyside6 * See above gi-loadouts.noarch: W: no-manual-page-for-binary gi-loadouts gi-loadouts.spec:12: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 5) 2 packages and 0 specfiles checked; 2 errors, 4 warnings, 11 filtered, 2 badness; has taken 11.5 s * Not sure which spec file is the authoritative one 😉, but decide on either tabs or spaces. Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 gi-loadouts.noarch: E: spelling-error ('gameplay', '%description -l en_US gameplay -> game play, game-play, nameplate') gi-loadouts.noarch: W: python-leftover-require python-pillow-qt gi-loadouts.noarch: W: python-leftover-require python-pyside6 gi-loadouts.noarch: W: no-manual-page-for-binary gi-loadouts 1 packages and 0 specfiles checked; 1 errors, 3 warnings, 7 filtered, 1 badness; has taken 0.9 s Source checksums ---------------- https://github.com/gridhead/gi-loadouts/releases/download/0.1.9/gi_loadouts-0.1.9-custom.tar.gz : CHECKSUM(SHA256) this package : 4e380e7a943f47b57dcc866b9bc12dd31a28a2b8dd7299e3a0b73bc61909054e CHECKSUM(SHA256) upstream package : 4e380e7a943f47b57dcc866b9bc12dd31a28a2b8dd7299e3a0b73bc61909054e Requires -------- gi-loadouts (rpmlib, GLIBC filtered): (python3.14dist(pillow) < 12~~ with python3.14dist(pillow) >= 10.4) (python3.14dist(pydantic) < 3~~ with python3.14dist(pydantic) >= 2.8.2) (python3.14dist(pytesseract) < 0.4~~ with python3.14dist(pytesseract) >= 0.3.13) (python3.14dist(pyyaml) < 7~~ with python3.14dist(pyyaml) >= 6.0.2) /usr/bin/python3 python(abi) python-pillow-qt python-pyside6 tesseract Provides -------- gi-loadouts: application() application(org.gridhead.gi-loadouts.desktop) gi-loadouts metainfo() metainfo(org.gridhead.gi-loadouts.metainfo.xml) python3.14dist(gi-loadouts) python3dist(gi-loadouts) Diff spec file in url and in SRPM --------------------------------- --- /home/nils/devel/reviews/fedora/2379712-gi-loadouts/srpm/gi-loadouts.spec 2025-07-15 12:21:57.276020702 +0200 +++ /home/nils/devel/reviews/fedora/2379712-gi-loadouts/srpm-unpacked/gi-loadouts.spec 2025-07-12 02:00:00.000000000 +0200 @@ -1,23 +1,23 @@ -%global pack gi-loadouts -%global srce gi_loadouts -%global uuid org.gridhead.gi-loadouts - -Name: %{pack} -Version: 0.1.9 -Release: 1%{dist} -Summary: Loadouts for Genshin Impact +%global pack gi-loadouts +%global srce gi_loadouts +%global uuid org.gridhead.gi-loadouts + +Name: %{pack} +Version: 0.1.9 +Release: 1%{dist} +Summary: Loadouts for Genshin Impact -License: GPL-3.0-or-later -URL: https://github.com/gridhead/%{pack} +License: GPL-3.0-or-later +URL: https://github.com/gridhead/%{pack} Source0: %{url}/releases/download/%{version}/%{srce}-%{version}-custom.tar.gz -BuildArch: noarch +BuildArch: noarch -BuildRequires: python3-devel +BuildRequires: python3-devel BuildRequires: desktop-file-utils BuildRequires: libappstream-glib -Requires: tesseract -Requires: python-pillow-qt +Requires: tesseract +Requires: python-pillow-qt Requires: python-pyside6 Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2379712 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: C/C++, Perl, Ocaml, fonts, PHP, Haskell, R, SugarActivity, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2379712 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202379712%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
