https://bugzilla.redhat.com/show_bug.cgi?id=2374723 --- Comment #4 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- > Replace > %global mpd_rundir /run/mpd > with > %global mpd_rundir %{_rundir}/mpd Done >> License: GPL-2.0-only AND BSD-2-Clause AND ISC AND LGPL-2.1-only > 1. Licensing break-down is missing. The following licenses are not listed: > ./src/pcm/Dsd2Pcm.cxx: BSD-2-Clause-Views > ./src/pcm/Dsd2Pcm.hxx: BSD-2-Clause-Views > ./src/pcm/ReplayGainAnalyzer.cxx: LGPL-2.1-or-later > ./src/pcm/ReplayGainAnalyzer.hxx: LGPL-2.1-or-later Fixed >> # Note that the 0.18.x branch doesn't yet work with Fedora's version of >> # libmpcdec which needs updating. >> # https://bugzilla.redhat.com/show_bug.cgi?id=1014468 >> # http://bugs.musicpd.org/view.php?id=3814#bugnotes > 2. Given that this is version 0.24, are the above comments still relevant? bug 1014468 is long closed. Fixed >> Patch0: mpd-0.24-mpdconf.patch >> Patch1: mpd-0.24-remove_NoNewPrivileges.patch >> Patch2: timidity_path.patch > 3. Patches should have either upstream bug or PR references or a comment why they're downstream only. Added comments. > 4. Please sort BuildRequires: alphabetically. Most of them could be converted to pkgconfig() style, too. Sorted alphabetically. Why is pkgconfig() style preferable? spec: https://fed500.fedorapeople.org/mpd.spec srpm: https://fed500.fedorapeople.org/mpd-0.24.4-3.fc43.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2374723 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202374723%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
