https://bugzilla.redhat.com/show_bug.cgi?id=2373136 --- Comment #14 from Neal Gompa <ngompa13@xxxxxxxxx> --- > Source: %{url}/archive/refs/tags/v%{version}.tar.gz This should use the format "%{url}/archive/v%{version}/%{name}-%{version}.tar.gz" > Group: Development/Libraries/C and C++ This should be dropped. > %autosetup -n %{name}-%{version} -p1 This can be simplified to "%autosetup -p1" > %{_libdir}/libtsm.so.* This needs to have the soversion tracked, like so: "%{_libdir}/libtsm.so.4{,.*}" Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2373136 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202373136%23c14 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
