[Bug 2376217] Review Request: openbao - A tool for securely accessing secrets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2376217



--- Comment #8 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> ---
> when I removed `%global debug_package %{nil}` than what was in the comment: "Empty %files file debugsourcefiles.list".
> I saw a suggestion on the internet to not strip symbols if that error is hit, but removing the strip command didn't help.
> I had previously inserted the strip command because fedora-review noticed that the bao binary wasn't stripped.

You shouldn't strip it manually. I'm not 100% sure if this is enough, but
shouldn't be needed.

Use %gobuild macro instead of "go build", that way Fedora's default builds
flags are used.

You can check a simple spec like Opentofu's to see how simple the spec can be.
Macros apply even if you don't want to use go-vendor tools.

https://src.fedoraproject.org/rpms/opentofu/blob/rawhide/f/opentofu.spec

If you want to change the default flags, you can check how kubernetes spec is
doing it:

https://src.fedoraproject.org/rpms/kubernetes1.33/blob/rawhide/f/kubernetes1.33.spec#_259


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2376217

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202376217%23c8

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux