https://bugzilla.redhat.com/show_bug.cgi?id=2360119 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #35 from Fabio Valentini <decathorpe@xxxxxxxxx> --- > Problem is the library links udev, so anyone using the library gets the udev > dependency even if the functionality actually needing udev is not used ... > > Maybe I can hide the udev dependeny behind a feature flag, so we can have > two variants of the library, with and without udev ... You don't need two variants, just specify which executable needs the udev feature and which doesn't. Then building the executables with only the features they need should avoid the over-linking. And I see that you've basically done this in the latest version, and the overlinking warning from rpmlint is gone. Great! === Changes look good to me, some minor things left (that doesn't block the review): 1. The typo in the Summary is back, it's "firmwarea" again. 2. Mixed use of tabs and spaces - please indent lines 22-30 with spaces, not tabs. 3. You wrapped the %check section in an %if %{with check} conditional, but don't actually define this bcond. Please add "%bcond check 1" (or "0" if you can't run tests, and document *why*) at the top of the spec file. I don't see any other remaining issues, so I'll mark the package as APPROVED (but please fix these three before importing the spec file). === ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide 🫤 test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ licenses of statically linked dependencies are correctly taken into account ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2360119 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202360119%23c35 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
