[Bug 2376545] Review Request: golang-codeberg-gbcox-mpris-webhook - Webhook Generator for MPRIS enabled players

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2376545



--- Comment #4 from Gerald Cox <gbcox@xxxxxx> ---
Hey Jerry, thanks for the quick turnaround.  
Regarding: - systemd_user_post is invoked in %post and systemd_user_preun in
%preun
  for Systemd user units service files.
  Note: Systemd user unit service file(s) in golang-codeberg-gbcox-mpris-
  webhook
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/Scriptlets/#_user_units

I did see that I tried added those statements and got the exact same message
so took them out:

Issues:
=======
- systemd_user_post is invoked in %post and systemd_user_preun in %preun
  for Systemd user units service files.
  Note: Systemd user unit service file(s) in golang-codeberg-gbcox-mpris-
  webhook
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/Scriptlets/#_user_units

I did also read the doc, and you are right it is confusing.  I really don't see
the
point in those statements.  This is systemd --user, so when this is installed
as root via dnf, it can't really install the service anyway.  It doesn't know
what
user is going to install.  The service file is installed earlier by %install,
so 
I'm not exactly sure what this is getting at.

If you want me to add it in to pass the review, I certainly can, but it appears
to be "not applicable" - or at the very least extremely confusing.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2376545

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202376545%23c4

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux