https://bugzilla.redhat.com/show_bug.cgi?id=2376298 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> --- (In reply to Katerina Koukiou from comment #1) > > Issues to address before approval: > > 1. Desktop File Missing: Slitherer is a GUI application, but no .desktop > file is installed. The intent is to reuse the desktop file from anaconda-live, so it doesn't make sense for it to have its own. Indeed, slitherer even identifies itself as Anaconda to the desktop. > 2. Incorrect Dependency: The spec incorrectly declares Requires: > anaconda-webui. Since anaconda-webui uses Slitherer (not the other way > around), this dependency should be removed from Slitherer’s spec and instead > added to anaconda-webui with the correct conditional. This will allow > Slitherer to be possibly used for other use cases without pulling in > Anaconda Web UI. No, it does depend on anaconda-webui as the default loading URL is the webui local address. > 3. %check Section Missing: Are you planning to add any tests? > Not currently? I don't know what kind of tests would be possible for this, since it's a simple shim to QtWebEngine. > Some non blocking comments: > > 1. Upstream files like main.cpp lack a copyright statement. Run > `licencecheck` command see the output. This is a false negative, it has one: https://gitlab.com/VelocityLimitless/Projects/slitherer/-/blob/main/main.cpp?ref_type=heads -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2376298 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202376298%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
