https://bugzilla.redhat.com/show_bug.cgi?id=2376217 --- Comment #2 from Dave Dykstra <dwd@xxxxxxx> --- Thanks for the quick feedback. > BuildRequires: systemd-rpm-macros > All the "%{?_isa}" can go. > There is a macro for /usr/lib/systemd/system/ - %{_unitdir} I think. Ok, good to know. I'll update those. > this package was never in Fedora so its simply not this packages problem to fix previous state Ok, I'll handle it then by making a transition release outside of Fedora and making sure all previous users upgrade to that first. I think it would be good to make sure the package is ready to be accepted first in case there are any other things I'll need in the transition release. > For the user/group add stuff please use a sysusers.d record Right, I had just figured that out because I saw an error installing into fedora 42. > All the bundling is hard for me however I know this has been relaxed a lot more with golang. This probably needs a real go packager to look at this. I used the exact same technique that is used in Fedora by apptainer and singularity-ce to create the Provides: bundled(golang()) statements and the LICENSE_DEPENDENCIES.md file. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2376217 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202376217%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue