https://bugzilla.redhat.com/show_bug.cgi?id=2055602 --- Comment #12 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Licensing seems ok, MIT license does not need to be in every file. A tagged release should be used, or if not the commit should be specified. As the package is a noarch package, testing on one architecture is fine. A smoke test could probably be added. It is not mandatory though, but good to indicate it as a possible useful addition. To check whether timestamps are preserved, check files in the rpms-unpacked folder using ls -lrt. Here it maybe useful to use ` install -pDm 0755 %{name} %{buildroot}/%{_bindir}/%{name} instead of mkdir -p %{buildroot}/%{_bindir} install -m 0755 %{name} %{buildroot}/%{_bindir}/%{name} -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2055602 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202055602%23c12 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
