https://bugzilla.redhat.com/show_bug.cgi?id=2375027 --- Comment #5 from Carl George 🤠 <carl@xxxxxxxxxx> --- The provides and obsoletes are still for python-ramalama, they need to be for python3-ramalama. ================================================================================ There is a provides for %{pypi_name}, but that matches %{name}, so it's effectively a duplicate and can be removed. -Provides: %{pypi_name} = %{version}-%{release} ================================================================================ The build requires on git-core and golang seem to be unnecessary, and the build works the same without them. ================================================================================ %{python3_sitelib}/ramalama doesn't need to be listed in the %files, because it's included as part of %{pyproject_files}. ================================================================================ The Name tag is set to the value of %{pypi_name}. It would be a bit more readable to define Name directly (`Name: ramalama`), drop the definition of %{pypi_name}, and just use %{name} everywhere else. This isn't mandatory for the review, just a suggestion. ================================================================================ While experimenting with this build, I noticed something I wanted to bring up. If you run `make docs` during the %build, the man pages are generated sooner, and then included in the wheel. The shell completions and the shortnames.conf file are also included in the wheel. The only thing not included is ramalama.conf. If pyproject.toml is modified to included ramalama.conf as a data file in the wheel similar to shortnames.conf, then we don't need to run any of the make targets in %install, just the docs target in %build. What do you think? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2375027 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202375027%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
